Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't give binary serialization properties optional types. #816

Open
jespertheend opened this issue Nov 15, 2023 · 0 comments
Open

Don't give binary serialization properties optional types. #816

jespertheend opened this issue Nov 15, 2023 · 0 comments
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Binary Serialization Related to serializing/deserializing objects using util/binarySerialization.js
Milestone
V1.0

Comments

@jespertheend
Copy link
Collaborator

Binary serialization automatically fills in missing parameters with default values, i.e. StorageType.UINT16 becomes 0 etc.
So the types of the first argument of objectToBinary() are all optional.
But in practice this can be pretty annoying because you don't get any early warnings when you forgot to provide one of the messages.
@jespertheend jespertheend added effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Binary Serialization Related to serializing/deserializing objects using util/binarySerialization.js labels Nov 15, 2023
@jespertheend jespertheend added this to the V1.0 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Binary Serialization Related to serializing/deserializing objects using util/binarySerialization.js
Projects
None yet
Milestone
V1.0
Development

No branches or pull requests
1 participant
@jespertheend