Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass referrer between clients of the internal discovery method #811

Open
jespertheend opened this issue Nov 3, 2023 · 0 comments
Open
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors.
Milestone

Comments

@jespertheend
Copy link
Collaborator

To determine whether a connection should be automatically accepted, it would be useful to know the origin of the connection.
In case of the internal discovery method, we can make sure the created iframe has referrerpolicy set to something permissive.
The iframe can then pass on the referrer to the shared worker.
This allows other clients to determine whether they want to automatically accept connections or not.

The WebRtcDiscoveryMethod won't really be able to make use of this unfortunately.
Since anyone can open a connection to the WebSocket, they could easily spoof the origin header.

@jespertheend jespertheend added effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors. labels Nov 3, 2023
@jespertheend jespertheend added this to the backlog milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. topic: Studio Connections Related to messaging connection discovery between studio instances or inspectors.
Projects
None yet
Development

No branches or pull requests

1 participant