Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypedMessenger needs a hook for error serialization. #485

Closed
jespertheend opened this issue Mar 29, 2023 · 0 comments · Fixed by #486
Closed

TypedMessenger needs a hook for error serialization. #485

jespertheend opened this issue Mar 29, 2023 · 0 comments · Fixed by #486
Assignees
@jespertheend
Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible.
Milestone
backlog

Comments

@jespertheend
Copy link
Collaborator

Browsers currently don't support serializing Aggregate errors for instance, see whatwg/html#5749.
Also when a worker throws custom errors such as class MyError extends Error, these are not serialized either. This doesn't allow the main thread to catch it and check its type using instanceof.
@jespertheend jespertheend added the effort: Moderate Will take a good amount of time and experience with the codebase, but feasible. label Mar 29, 2023
@jespertheend jespertheend added this to the backlog milestone Mar 29, 2023
@jespertheend jespertheend self-assigned this Mar 29, 2023
@jespertheend jespertheend mentioned this issue Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jespertheend jespertheend

Labels
effort: Moderate Will take a good amount of time and experience with the codebase, but feasible.
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

feat: Add error serialization hooks to TypedMessenger jespertheend/Renda
1 participant
@jespertheend