Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package benchmark sources in the final jar #340

Open
farquet opened this issue Dec 17, 2021 · 2 comments
Open

Package benchmark sources in the final jar #340

farquet opened this issue Dec 17, 2021 · 2 comments

Comments

@farquet
Copy link
Collaborator

farquet commented Dec 17, 2021

Since there has been quite a lot of renaissance releases in the last couple of years, it may not be obvious for a user to locate the benchmark sources on GitHub for a given renaissance execution they're investigating locally.

Assuming the addition of sources wouldn't increase the jar size too much, we could consider packaging them inside the jar such that IDEs would pick them up automatically.

It is very simple to do with maven and its maven-source-plugin, but I can't find much around this for sbt though.

@axel22
Copy link
Member

axel22 commented Dec 19, 2021

Doesn't this happen by default when you publish?
Here's how to disable it:

Compile / packageSrc / publishArtifact := false,

https://www.scala-sbt.org/1.x/docs/Artifacts.html

@lbulej
Copy link
Member

lbulej commented Dec 20, 2021

Since there has been quite a lot of renaissance releases in the last couple of years

I might be a bit slow, but I don't completely get what is the problem we are trying to solve? We are not what I would describe as a fast-moving project (5 releases in 2 years)...

The releases get an automatic source snapshot. It's also possible to check out the release tag. For anything unreleased, i.e., built by people from the master branch between two releases, it's always possible to check out the specific commit id (which can be found in the manifest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants