New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Kill-Process GUI shown when nodemon restarts #1879
Comments
What GUI are you seeing? If you can provide a video or at least screenshots it would be useful. Once you've done that, can you also test by installing |
ok, like once the GUI freezed and i took a screenshot and started to write this bug, but soon my PC crashed and i lost the screen shot |
@remy |
And the same happens with |
I hadn't spotted you're on windows 7. Can you try with nodemon@2.0.7 and let me know if restarting works as expected? |
I was acctually using Nodemon@2.0.6 and then this happened, then I updated to see if it still remains a problem, and it was |
Oh wait I just tested @2.0.7 it worked as expected, also can you please put this issue up somewhere noticeable so if people have the same problem like me they can view this issue, Thanks you. 🙏 |
Instead of me closing it, you check everything and close it yourself, or you will be searching this issue later! |
What I'll try to do is fork the logic handling for the windows restart process the use the windows-kill.exe only if it's above or including windows 10. This way it won't catch people out. |
Nice so no more windows-kill.exe right, then how will we stop the nodemon process. eg: For nodemon it's process.once("SIGUSR2", function () {
gracefulShutdown(function () {
process.off();
process.kill(process.pid, "SIGUSR2");
}); then how will we stop the nodemon process if you implement it? |
I'll restore the fork of code logic that handles the restart in 2.0.7 for < windows 10. |
oK cool, I think you are close this issue |
Can you try to install (an updated) |
I am having the same issue in my nodejs project. As soon as I update the app.js in my project, error shows as |
@DineshRout779 you'll need to actually tell us what version of nodemon you're using… |
@Nigelrex this landed in 2.0.10 - so windows-kill is only used in Windows 10 and above. |
but it worked for me 😄 |
Nodemon :- 2.0.10 |
nodemon -v
: v2.0.9node -v
: v12.9.1Expected behaviour
During file changes and restarting of nodemon, only the terminal should be showing restarting and the kill-process should be triggered, and there should be no-GUI popping up with the name Kill-process.
Actual behaviour
Same as above but the kill-process Terminal pops up during file changes and restart
Steps to reproduce
I am not sure how that came, I started nodemon as usual and this happened
If applicable, please append the
--dump
flag on your command and include the output here ensuring to remove any sensitive/personal details or tokens.The text was updated successfully, but these errors were encountered: