Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.8 [Windows 10] globally installed nodemon broken (looking for windows-kill.exe locally) #1872

Closed
Velesarix opened this issue Jun 29, 2021 · 8 comments · Fixed by #1874
Closed

Comments

@Velesarix
Copy link

Velesarix commented Jun 29, 2021

With the new 'windows-kill' merge in version 2.0.8 it brakes globally installed nodemon restarts. It says it is looking for the windows-kill binary in the local node_modules folder, but obviously if I am running nodemon from a global install, it's package wont be in the local node_modules

Here is the error I receive; and you can see I dont have nodemon installed locally on this project
nodemon2 0 8
nodemon2 0 8ver

Here is the same project using nodemon 2.0.7; and the global nodemon works fine
nodemon2 0 7

  • nodemon -v: 2.0.8
  • node -v: 16.4.0
  • Operating system/terminal environment: Windows 10
  • Command you ran: nodemon src/main.ts

Steps to reproduce

Install nodemon with npm i -g npm@latest, verify its version 2.0.8 with nodemon -v then run nodemon without a local project install

I want to clarify, that a local install within the project will work with v2.0.8; its just when you try to run it from a global only install

@remy
Copy link
Owner

remy commented Jun 29, 2021

cc'ing @countzero - looks like this is simple to replicate, would be good to solve this quickly - I might be able to work it out too myself…

@remy remy added the windows label Jun 29, 2021
@remy
Copy link
Owner

remy commented Jun 29, 2021

@Ericarthurc thanks for the clear explanation 👍

@remy remy added the bug confirmed bug label Jun 29, 2021
@unshDee
Copy link

unshDee commented Jun 29, 2021

Glad to see the issue's been raised here (didn't find anything related to it until I landed here). I had installed nodemon globally today, and faced the same problem whenever I updated my code.

  • nodemon -v: 2.0.8
  • node -v: 14.17.1

@remy
Copy link
Owner

remy commented Jun 30, 2021

For my own reference, this is the line in question: https://github.com/remy/nodemon/pull/1853/files#diff-5421faa69288694e0e190b2e6108ec30df01af1b84c6c2d68274f2a31596768eR350

Needs to be "smart".

@remy
Copy link
Owner

remy commented Jun 30, 2021

Can folks here try both local and global installs of nodemon@debug - I'm trying to get my local windows environment running so I can test it myself too.

To install the test version:

npm install -g nodemon@debug

@remy
Copy link
Owner

remy commented Jun 30, 2021

I'm 90% sure this is fixed in the debug build so I'm going to ship it.

@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@countzero
Copy link
Contributor

Oups, my bad... A relative path to the executable makes sense!

@remy thanks for merging and fixing it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants