From 1e320c6fcec0ff6925f54b4813086c3bd61a81c5 Mon Sep 17 00:00:00 2001 From: Roj Date: Sun, 13 Nov 2022 22:17:16 +0300 Subject: [PATCH 1/2] chore(docs): fix two small typos --- ...01-use-npm-to-manage-npm-dependencies-for-deno-projects.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md b/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md index 46853296f58..35a6ec0a363 100644 --- a/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md +++ b/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md @@ -12,7 +12,7 @@ Deno has three ways to manage dependencies: 2. [deps.ts](https://deno.land/manual/examples/manage_dependencies) 3. [Import maps](https://deno.land/manual/linking_to_external_code/import_maps) -Additionally, NPM packages can be accessed as Deno modules via [Deno-friendly CDNs](https://deno.land/manual/node/cdns#deno-friendly-cdns) like https://esm.sh . +Additionally, NPM packages can be accessed as Deno modules via [Deno-friendly CDNs](https://deno.land/manual/node/cdns#deno-friendly-cdns) like https://esm.sh. Remix has some requirements around dependencies: @@ -78,7 +78,7 @@ Remix will not yet support import maps. ## Consequences -- URL imports will not be treeshaken +- URL imports will not be treeshaken. - Users can specify environment via the `NODE_ENV` environment variable at runtime. - Users won't have to do error-prone, manual dependency resolution. From ec40e57bb5a78bf7132d2fb0ab970bea21d9cf5e Mon Sep 17 00:00:00 2001 From: Roj Date: Sun, 13 Nov 2022 22:18:43 +0300 Subject: [PATCH 2/2] Update contributors.yml --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index c1eb99ae3d5..e655927d0d2 100644 --- a/contributors.yml +++ b/contributors.yml @@ -363,6 +363,7 @@ - RomanSavarin - ronnylt - rossipedia +- roj1512 - RossJHagan - RossMcMillan92 - rowinbot