From 2e40682dee1e0fda90fbac653067decb10ebd711 Mon Sep 17 00:00:00 2001 From: Shai Reznik Date: Mon, 8 Aug 2022 12:49:08 +0300 Subject: [PATCH 1/4] docs: fix a typo in jokeId param --- docs/tutorials/jokes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/jokes.md b/docs/tutorials/jokes.md index c1620150fd1..f3543123b9e 100644 --- a/docs/tutorials/jokes.md +++ b/docs/tutorials/jokes.md @@ -400,7 +400,7 @@ Soon we'll add a database that stores our jokes by an ID, so let's add one more `/jokes/:jokeId` -Here the parameter `$jokeId` can be anything, and we can lookup that part of the URL up in the database to display the right joke. To make a parameterized route, we use the `$` character in the filename. ([Read more about the convention here][the-route-filename-convention]). +Here the parameter `:jokeId` can be anything, and we can lookup that part of the URL up in the database to display the right joke. To make a parameterized route, we use the `$` character in the filename. ([Read more about the convention here][the-route-filename-convention]). 💿 Create a new route at `app/routes/jokes/$jokeId.tsx`. Don't worry too much about what it displays for now (we don't have a database set up yet!): From 9017d4a67fa145d878f801b3c320cb29370f5baa Mon Sep 17 00:00:00 2001 From: Shai Reznik Date: Tue, 30 Aug 2022 00:53:11 -0600 Subject: [PATCH 2/4] adding shairez as a contributor to be able to merge the smallest of the PRs :) --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index 550968b1cf1..bf3c1adcf8c 100644 --- a/contributors.yml +++ b/contributors.yml @@ -353,6 +353,7 @@ - sergiocarneiro - sergiodxa - shashankboosi +- shairez - shumuu - sidkh - sidv1905 From ff4b44b2d3657667c4875db5a6d6d5a5c41a56f3 Mon Sep 17 00:00:00 2001 From: Shai Reznik Date: Tue, 30 Aug 2022 00:55:16 -0600 Subject: [PATCH 3/4] docs: Update docs/tutorials/jokes.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Michaël De Boey --- docs/tutorials/jokes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/jokes.md b/docs/tutorials/jokes.md index f3543123b9e..aa88b9c3306 100644 --- a/docs/tutorials/jokes.md +++ b/docs/tutorials/jokes.md @@ -398,7 +398,7 @@ Great, so now going to [`/jokes/new`][jokes-new] should display your form: Soon we'll add a database that stores our jokes by an ID, so let's add one more route that's a little more unique, a parameterized route: -`/jokes/:jokeId` +`/jokes/$jokeId` Here the parameter `:jokeId` can be anything, and we can lookup that part of the URL up in the database to display the right joke. To make a parameterized route, we use the `$` character in the filename. ([Read more about the convention here][the-route-filename-convention]). From 582168556d1090e3c3c2076d460526f089cedbd7 Mon Sep 17 00:00:00 2001 From: Shai Reznik Date: Tue, 30 Aug 2022 00:55:34 -0600 Subject: [PATCH 4/4] docs: Update docs/tutorials/jokes.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Michaël De Boey --- docs/tutorials/jokes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tutorials/jokes.md b/docs/tutorials/jokes.md index aa88b9c3306..528786a7b6b 100644 --- a/docs/tutorials/jokes.md +++ b/docs/tutorials/jokes.md @@ -400,7 +400,7 @@ Soon we'll add a database that stores our jokes by an ID, so let's add one more `/jokes/$jokeId` -Here the parameter `:jokeId` can be anything, and we can lookup that part of the URL up in the database to display the right joke. To make a parameterized route, we use the `$` character in the filename. ([Read more about the convention here][the-route-filename-convention]). +Here the parameter `$jokeId` can be anything, and we can lookup that part of the URL up in the database to display the right joke. To make a parameterized route, we use the `$` character in the filename. ([Read more about the convention here][the-route-filename-convention]). 💿 Create a new route at `app/routes/jokes/$jokeId.tsx`. Don't worry too much about what it displays for now (we don't have a database set up yet!):