Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade esbuild to v0.15.13+ #4788

Closed
1 task done
pcattori opened this issue Dec 6, 2022 · 3 comments · Fixed by #4754
Closed
1 task done

Upgrade esbuild to v0.15.13+ #4788

pcattori opened this issue Dec 6, 2022 · 3 comments · Fixed by #4754
Assignees

Comments

@pcattori
Copy link
Contributor

pcattori commented Dec 6, 2022

Progress

Related issues

Context

Upgrading to esbuild v0.15.13 or newer is causing our integration tests to hang indefinitely.
This happens only when our compiler is run via spawned process.

@mcansh and @pcattori have looked into this and narrowed the problem down to the browser build.
We were able to reproduce the tests hanging locally and then saw that changing the browser build to be non-incremental fix the issue. However, this did not fix the issue in CI.

I was able to also reproduce the issue outside of tests by writing a simple script that used cross-spawn and/or execa to run remix build from within a child process.

We need to dig a bit more to see if this is a bug in one of our esbuild plugins or something else.

@pcattori pcattori self-assigned this Dec 6, 2022
@pcattori pcattori changed the title upgrading esbuild Upgrade esbuild to v0.15.13+ Dec 6, 2022
@pcattori
Copy link
Contributor Author

pcattori commented Dec 8, 2022

Made some progress on this today. The compiler builds normally, but when the CLI calls process.exit() the node process hangs indefinitely. Seems to be caused by an active resource/handle opened by the esbuild process.

Made an issue for esbuild here: evanw/esbuild#2727

@pcattori
Copy link
Contributor Author

pcattori commented Dec 8, 2022

Confirmed that this is a bug introduced in esbuild 0.15.13: evanw/esbuild#2485 (comment)

@pcattori
Copy link
Contributor Author

pcattori commented Dec 9, 2022

esbuild 0.16.3 should fix this: https://github.com/evanw/esbuild/releases/tag/v0.16.3

@mcansh mcansh linked a pull request Dec 9, 2022 that will close this issue
2 tasks
@pcattori pcattori closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant