Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion Example app re-renders every time (exceeding maximum update depth) #2349

Closed
PJColombo opened this issue Mar 16, 2022 · 2 comments
Closed

Comments

@PJColombo
Copy link

What version of Remix are you using?

1.2.3

Steps to Reproduce

  1. Download Emotion example app repo: svn export https://github.com/remix-run/remix/tree/main/examples/emotion

  2. Install dependencies: yarn

  3. Run app: yarn dev

  4. Look at the console

Expected Behavior

An app that doesn't perform unnecessary re-renders.

Actual Behavior

If you look at the console tab, you get the following:

image

@PJColombo PJColombo added the bug Something isn't working label Mar 16, 2022
@chaance chaance added examples: bug and removed bug Something isn't working labels Mar 16, 2022
@machour
Copy link
Collaborator

machour commented Mar 17, 2022

Tracked in remix-run/examples#1 (which was re-opened after you posted this issue, but have more information about what's going on)

@PJColombo
Copy link
Author

Got it. I'll close this issue then and follow the discussion on the other one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants