Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade shiki #237

Open
brookslybrand opened this issue Mar 25, 2024 · 2 comments
Open

Upgrade shiki #237

brookslybrand opened this issue Mar 25, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@brookslybrand
Copy link
Contributor

Shiki, our code syntax highlighter, has undergone a number of upgrades since the current version we have (0.14.7). This is a major version upgrade, so there are some breaking changes

Migration guide

In order to stay up to date with bug fixes and the latest and greatest we should invest in upgrading this package

@brookslybrand brookslybrand added the good first issue Good for newcomers label Mar 25, 2024
@tlawrie
Copy link

tlawrie commented May 23, 2024

@brookslybrand could we use https://rehype-pretty.pages.dev/? I have swapped out the custom shiki for this in a fork and it works.

I didn't try it with custom themes as with yours, however it does have a themes option which might work.

@brookslybrand
Copy link
Contributor Author

@brookslybrand could we use https://rehype-pretty.pages.dev/? I have swapped out the custom shiki for this in a fork and it works.

I didn't try it with custom themes as with yours, however it does have a themes option which might work.

I'm not totally against it, but since I didn't really build this part and try to not touch it too much since it's all working correctly, I'm a bit hesitant to change it. Do you think it'd just be more maintainable? I'm open to a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants