From f45eda1b50d0647b3eafe422bb9a60902858d68b Mon Sep 17 00:00:00 2001 From: Christopher Chudzicki Date: Fri, 14 Jan 2022 14:42:30 -0500 Subject: [PATCH 1/2] fix(tutorial): use "root" as root div id The documentation in /docs/getting-started uses "root" as the root element id, including in code snippets. So if a learner is following the tutorial documentation, they'll break their app when they copy-paste the tutorial snippets (which use "root") into the template (which was using "app"). Now the docs and the template both use "root". --- tutorial/index.html | 2 +- tutorial/src/main.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tutorial/index.html b/tutorial/index.html index 3e91e89f3d..bb0aca7e07 100644 --- a/tutorial/index.html +++ b/tutorial/index.html @@ -6,7 +6,7 @@ React Router - Tutorial -
+
diff --git a/tutorial/src/main.jsx b/tutorial/src/main.jsx index 514b32507b..8a3cadb896 100644 --- a/tutorial/src/main.jsx +++ b/tutorial/src/main.jsx @@ -3,5 +3,5 @@ import * as ReactDOM from "react-dom"; import App from "./App"; import "./main.css"; -let rootElement = document.getElementById("app"); +let rootElement = document.getElementById("root"); ReactDOM.render(, rootElement); From 7445d697c0ae118eabc779045352311b9f6014df Mon Sep 17 00:00:00 2001 From: Christopher Chudzicki Date: Fri, 14 Jan 2022 15:00:41 -0500 Subject: [PATCH 2/2] sign cla --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index b461e8d886..5b6e727522 100644 --- a/contributors.yml +++ b/contributors.yml @@ -2,6 +2,7 @@ - brockross - chaance - chasinhues +- christopherchudzicki - elylucas - hongji00 - JakubDrozd