fix: Normalize pathnameBase when matching #8533
Conversation
|
Hi @Isammoc, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Nearly I month. Can someone look for my PR or tell me what am I doing wrong, please? |
|
Hi @Isammoc - thank you for the PR! I think this is in good shape. Would you be able to resolve the conflicts so this is in a spot where we can merge it? Thanks! |
Motivation: When matching with "*", the `pathnameBase` had a trailing slash `/`. Modifications: * Call normalizePathname for pathnameBase Result: We can use an element that call useRoutes to define another alternative router for matching with "*". Closes: #8458
|
@brophdawg11 Thank you for your message! Here I rebased my PR. |
|
Thanks |
As no member confirm or refuse my issue #8458.
Here a PR that fix the bug for me.
Not sure if this is the best place to call normalizePathname, though.
Do not hesitate to comment, I will gladly change my PR.
----- Commit message -----
Motivation:
When matching with "*", the
pathnameBasehad a trailing slash/.Modifications:
Result:
We can use an element that call useRoutes to define another alternative router for matching with "*".
Closes: #8458