From 532397fc9e7bfdb819bfef2ff2a1bdf26eb78afd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernt=20R=C3=B8skar=20Brenna?= Date: Mon, 3 Oct 2022 19:58:30 +0200 Subject: [PATCH 1/3] failing test for bug 9392 --- .../__tests__/link-href-test.tsx | 45 ++++++++++++++++++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/packages/react-router-dom/__tests__/link-href-test.tsx b/packages/react-router-dom/__tests__/link-href-test.tsx index 9ec368fc70..f0be7b5fa2 100644 --- a/packages/react-router-dom/__tests__/link-href-test.tsx +++ b/packages/react-router-dom/__tests__/link-href-test.tsx @@ -1,6 +1,15 @@ import * as React from "react"; import * as TestRenderer from "react-test-renderer"; -import { MemoryRouter, Routes, Route, Link, Outlet } from "react-router-dom"; +import { + MemoryRouter, + Routes, + Route, + Link, + Outlet, + HashRouter, + createHashRouter, + RouterProvider +} from "react-router-dom"; describe(" href", () => { describe("in a static route", () => { @@ -679,4 +688,38 @@ describe(" href", () => { ); }); }); + + describe("when using ", () => { + test("rendered hrefs contain #", () => { + let renderer: TestRenderer.ReactTestRenderer; + TestRenderer.act(() => { + renderer = TestRenderer.create( + + + } /> + + + ); + }); + expect(renderer.root.findByType("a").props.href).toEqual("#/about"); + }); + }) + + describe("when using createHashRouter", () => { + test("rendered hrefs contain #", () => { + let renderer: TestRenderer.ReactTestRenderer; + TestRenderer.act(() => { + const router = createHashRouter([ + { + path: "/", + element: + } + ]); + renderer = TestRenderer.create( + + ); + }); + expect(renderer.root.findByType("a").props.href).toEqual("#/about"); + }); + }); }); From d32332476ee20718083b99d98dc9e2ce004b8f9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernt=20R=C3=B8skar=20Brenna?= Date: Mon, 3 Oct 2022 20:03:57 +0200 Subject: [PATCH 2/3] missing semicolon --- packages/react-router-dom/__tests__/link-href-test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-router-dom/__tests__/link-href-test.tsx b/packages/react-router-dom/__tests__/link-href-test.tsx index f0be7b5fa2..01fd6905d4 100644 --- a/packages/react-router-dom/__tests__/link-href-test.tsx +++ b/packages/react-router-dom/__tests__/link-href-test.tsx @@ -703,7 +703,7 @@ describe(" href", () => { }); expect(renderer.root.findByType("a").props.href).toEqual("#/about"); }); - }) + }); describe("when using createHashRouter", () => { test("rendered hrefs contain #", () => { From 5f22be04f5c67e27ec5d011f8169c126ca80f5ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernt=20R=C3=B8skar=20Brenna?= Date: Mon, 3 Oct 2022 20:07:23 +0200 Subject: [PATCH 3/3] CLA --- contributors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.yml b/contributors.yml index 205fe06b05..1f2681fc79 100644 --- a/contributors.yml +++ b/contributors.yml @@ -19,6 +19,7 @@ - chensokheng - chrisngobanh - christopherchudzicki +- codeape2 - coryhouse - cvbuelow - david-crespo