Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(socket.io): rename to socket-io #268

Closed

Conversation

MichaelDeBoey
Copy link
Member

Closes #267

@brophdawg11
Copy link

Is there a way we can fix this in the CLI? It seems prohibitive to have to say "templates cannot contain a dot". What are the supported extensions if pointing to a file - .tgz and maybe .git? Maybe we can only try to download the file if it matches those and otherwise treat it as a folder in a repo?

@brophdawg11
Copy link

@markdalgleish Do you know if this is still an issue in the new v2 create-remix CLI? If so is it something we can handle?

@brophdawg11 brophdawg11 removed their request for review August 2, 2023 15:52
@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Aug 25, 2023

Just tried running npx create-remix@nightly test-project --template examples/socket.io and got the following error:

      ◼  Directory: Using test-project as project directory

      ◼  Template: Using remix-run/examples/socket.io...

      ▲  Oh no! "examples/socket.io" is an invalid template. Run create-remix --help to see supported template formats.

Same when trying with remix-run/examples/socket.io:

      ◼  Directory: Using test-project as project directory

      ◼  Template: Using remix-run/examples/socket.io...

      ▲  Oh no! "remix-run/examples/socket.io" is an invalid template. Run create-remix --help to see supported template formats.

@brophdawg11
Copy link

I'm going to close this in favor of allowing shorthand folders to contain dots in remix-run/remix#7277

@MichaelDeBoey MichaelDeBoey deleted the rename-socket-io-folder branch August 28, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using template as specified does not seem to work
3 participants