Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fly apps create" not working correctly anymore #138

Closed
marko-x opened this issue Dec 2, 2022 · 5 comments
Closed

"fly apps create" not working correctly anymore #138

marko-x opened this issue Dec 2, 2022 · 5 comments

Comments

@marko-x
Copy link

marko-x commented Dec 2, 2022

Have you experienced this bug with the latest version of the template?

yes

Steps to Reproduce

  • Follow the steps in the readme.
  • "fly apps create [...]" not working correctly.

It creates an an app on fly.io but without an ip address. The created app has a orange wrench symbol. The app missing configurations.

Expected Behavior

Following the readme should lead you to have a running app.

Actual Behavior

Follow the readme will not working anymore, because fly.io app (remix) will not have an IP Address.

@pyyding
Copy link

pyyding commented Dec 11, 2022

The problem is caused by a missing FLY_REGION env variable in the GitHub deploy.yml action. For time being I suggest you to edit your deployment script to include it manually.

To both 🚀 Deploy Staging and 🚀 Deploy Production steps under the env section you need to add your database region.

You can find the region code when you create the db or

  1. Go to Fly.io dashboard
  2. Open your Postgres instance
  3. Open the "Machines" tab
  4. Copy the region code

The .github/deploy.yml env section should look something like this:

      - name: 🚀 Deploy Production
        ...
        env:
          FLY_REGION: "ams"
          FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}

@machour
Copy link
Collaborator

machour commented Dec 12, 2022

@pyyding do you want to submit a PR to fix this?

@github-actions
Copy link
Contributor

This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed.

@github-actions github-actions bot added the needs-response We need a response from the original author about the issue label Apr 17, 2023
@github-actions
Copy link
Contributor

This issue has been automatically closed because we didn't hear anything from the original author after the previous notice.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2023
@MichaelDeBoey
Copy link
Member

@marko-x @pyyding Will this be fixed if you apply the same changes as I did in #178?

@MichaelDeBoey MichaelDeBoey reopened this Apr 25, 2023
@github-actions github-actions bot removed the needs-response We need a response from the original author about the issue label Apr 25, 2023
@machour machour closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants