Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new GFM alerts #62

Closed
4 tasks done
matifali opened this issue Dec 20, 2023 · 5 comments
Closed
4 tasks done

support new GFM alerts #62

matifali opened this issue Dec 20, 2023 · 5 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@matifali
Copy link

matifali commented Dec 20, 2023

Initial checklist

Problem

Support the new GitHub Alters notation. There were previous requests in #53 and #54.

Note

Useful information that users should know, even when skimming content.

Tip

Helpful advice for doing things better or more easily.

Important

Key information users need to know to achieve their goal.

Warning

Urgent info that needs immediate user attention to avoid problems.

Caution

Advises about risks or negative outcomes of certain actions.

Solution

Have native support for this notation.

Alternatives

An alternative library is remark-github-beta-blockquote-admonitions

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 20, 2023
@wooorm
Copy link
Member

wooorm commented Dec 20, 2023

Duplicate of #53

@wooorm wooorm marked this as a duplicate of #53 Dec 20, 2023
@wooorm wooorm closed this as completed Dec 20, 2023
@wooorm wooorm added the 👯 no/duplicate Déjà vu label Dec 20, 2023

This comment has been minimized.

Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Dec 20, 2023
@wooorm
Copy link
Member

wooorm commented Dec 20, 2023

That is not an extension to GFM so doesn’t go here.
Instead, it’s something that would go in rehypejs/rehype-github, or as you mentioned, in another plugin.

@calumk
Copy link

calumk commented Jan 17, 2024

For future reference, plugin here : https://github.com/chrisweb/rehype-github-alerts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants