Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React 18.3.0/19.0.0 support for react-markdown ^6.0.0 #828

Closed
4 tasks done
janpe opened this issue May 8, 2024 · 2 comments
Closed
4 tasks done

React 18.3.0/19.0.0 support for react-markdown ^6.0.0 #828

janpe opened this issue May 8, 2024 · 2 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@janpe
Copy link

janpe commented May 8, 2024

Initial checklist

Problem

React 18.3.0 gives deprecation warnings for defaultProps usage still present in v6. This would be needed for users that are unable to support pure ESM at this point.

Solution

Remove defaultProps usage in v6 and publish a new release with the changes.

Alternatives

Without this change users are unable to move to React 19 with react-markdown if they need to support commonjs.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 8, 2024
@wooorm
Copy link
Member

wooorm commented May 8, 2024

Hey! Use v9.

It’s time to use ESM. You can upgrade your tools to support it.

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label May 8, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janpe @wooorm