Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible to Chrome 90 or older #822

Closed
4 tasks done
guoyunhe opened this issue Mar 22, 2024 · 9 comments
Closed
4 tasks done

Not compatible to Chrome 90 or older #822

guoyunhe opened this issue Mar 22, 2024 · 9 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@guoyunhe
Copy link

Initial checklist

Affected packages and versions

9.0.1

Link to runnable example

No response

Steps to reproduce

  1. Install Chrome 90 or use https://www.browserstack.com/
  2. Visit https://remarkjs.github.io/react-markdown/

Expected behavior

Should render

Actual behavior

Nothing render. Console show errors.

image

Runtime

Other (please specify in steps to reproduce)

Package manager

npm 8

OS

Windows

Build and bundle tools

Webpack

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 22, 2024
@JounQin
Copy link
Member

JounQin commented Mar 22, 2024

Chrome 90 is too old, and https://remarkjs.github.io/react-markdown is only for demo usage, I don't get why should we support Chrome 90.

We require ES2022 at b67d714

@JounQin JounQin closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024

This comment has been minimized.

@JounQin JounQin added the 🙅 no/wontfix This is not (enough of) an issue for this project label Mar 22, 2024
Copy link

Hi team! Could you describe why this has been marked as wontfix?

Thanks,
— bb

@guoyunhe
Copy link
Author

@JounQin the project's README claims:

They work in all modern browsers (essentially: everything not IE 11).

The reason why the package is not compatible to Chrome < 93 is that it uses Object.hasOwn. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn#browser_compatibility

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Mar 22, 2024
@JounQin
Copy link
Member

JounQin commented Mar 22, 2024

They work in all modern browsers (essentially: everything not IE 11).

That depends on what modern means, we can not support Chrome v1.0 of course.

@guoyunhe
Copy link
Author

That depends on what modern means, we can not support Chrome v1.0 of course.

You could add more clear definition in README.

@remcohaszing
Copy link
Member

This project is compatible with Node.js 16 and greater. That’s an exact definition. We don’t test across a matrix of different browser versions, so we don’t define the exact meaning of modern browser.

If you need to use modern features in an older browser, you can add a polyfill for missing APIs, or transpile modern syntax using Babel.

@JounQin
Copy link
Member

JounQin commented Mar 22, 2024

You could add more clear definition in README.

Indeed, unified projects basically require non-legacy node versions, but browsers support it's not well defined.

Or maybe that section should just be removed considering #772 (comment) and #804 (comment)

cc @wooorm and @ChristianMurphy

@wooorm
Copy link
Member

wooorm commented Mar 22, 2024

Object.hasOwn is intentional. Previous versions did not have it. The latest version does.
10 years ago I had browser matrix tests. Browser tests are error prone and don’t add much. Browsers nowadays are evergreen: they automatically update.
That’s why the text in the readme says: “They work in all modern browsers (essentially: everything not IE 11)”.

I don’t think we need to add a definition of every word in the readme. I think that the current description is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

4 participants