Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inapp links #809

Closed
4 tasks done
daniil00d opened this issue Jan 11, 2024 · 5 comments
Closed
4 tasks done

Support for inapp links #809

daniil00d opened this issue Jan 11, 2024 · 5 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@daniil00d
Copy link

Initial checklist

Problem

When inputting a link formatted as [hello]({any_app}://something) or <{any_app}://something>, a link node with an empty href is created.

Solution

I'd like the library to support this case: we input a link to an application (installed on the current device), and upon clicking said link, the application is opened. An example being: click me

Alternatives

One potential solution could be to give the user more control over the transformation of links obtained from the text. This could be achieved, for example, by extending the transformLinkUri prop, where it would be possible to access the protocol, domain, pathname, query, etc.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 11, 2024
@ChristianMurphy
Copy link
Member

Welcome @daniil00d! 👋

They are supported, but disabled by default as they are insecure.
You can set your own URL transform in the options https://github.com/remarkjs/react-markdown#options
See #774 for some examples

@ChristianMurphy ChristianMurphy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024

This comment has been minimized.

Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

This comment was marked as resolved.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Jan 11, 2024
@ChristianMurphy
Copy link
Member

Duplicate of #774

@ChristianMurphy ChristianMurphy marked this as a duplicate of #774 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants