Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything is rerendered on change #393

Closed
FerusAndBeyond opened this issue Feb 26, 2020 · 3 comments
Closed

Everything is rerendered on change #393

FerusAndBeyond opened this issue Feb 26, 2020 · 3 comments
Labels
🤷 no/invalid This cannot be acted upon

Comments

@FerusAndBeyond
Copy link

This makes it unusable for live editing, will this be changed at any point?

@beamercola
Copy link

having this problem too - images reload constantly. Anybody have any workarounds for this?

@zolon4
Copy link

zolon4 commented Mar 1, 2020

+1 to say i'm having the same issue

@ChristianMurphy
Copy link
Member

For live editing, you do want it to rerender on change. 😉

I suspect what you mean is you want non-blocking rendering and potentially input debouncing. 🙂
#428 would make this easier, you can see a live demo at https://christianmurphy.github.io/react-remark/?path=/story/remark-component--default

some sample markdown with images to play with:

# header

1. ordered
2. list

![](https://via.placeholder.com/150)

* unordered
* list

![](https://via.placeholder.com/250)

@ChristianMurphy ChristianMurphy added the 🤷 no/invalid This cannot be acted upon label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon
Development

No branches or pull requests

4 participants