Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML parser: crashes if table described in one line #259

Closed
braska opened this issue Dec 19, 2018 · 5 comments · Fixed by #563
Closed

HTML parser: crashes if table described in one line #259

braska opened this issue Dec 19, 2018 · 5 comments · Fixed by #563
Labels
🐛 type/bug This is a problem

Comments

@braska
Copy link

braska commented Dec 19, 2018

I've opened https://rexxars.github.io/react-markdown/ and tried to check following snippet and all works fine:

<table>
  <tr>
    <td>1</td>
    <td>a</td>
  </tr>
</table>

But if I am trying to use this one all crashes:

<table><tr><td>1</td><td>a</td></tr></table>

Stack trace from console:

Uncaught TypeError: (el.props.children || []).concat is not a function
    at mergeNodeChildren (ast-to-react.js?5e65:214)
    at getNodeProps (ast-to-react.js?5e65:175)
    at astToReact (ast-to-react.js?5e65:18)
    at eval (ast-to-react.js?5e65:23)
    at Array.map (<anonymous>)
    at resolveChildren (ast-to-react.js?5e65:22)
    at astToReact (ast-to-react.js?5e65:19)
    at ReactMarkdown (react-markdown.js?2ced:58)
    at ReactMarkdownWithHtml (with-html.js?7ca6:13)
    at ProxyFacade (react-hot-loader.development.js?9cb3:705)
@nlucero
Copy link

nlucero commented Jan 15, 2019

Seems to be happening with any one-line HTML string

@plainnany
Copy link

same question

@te-online
Copy link

I can confirm that it throws that error with one-line HTML strings.
Adding a newline fixes it temporarily. Example:

<ReactMarkdown source={`${content}\r\n `} escapeHtml={false} astPlugins={[parseHtml]} />

@ChristianMurphy
Copy link
Member

this will be resolved in #428

@ChristianMurphy ChristianMurphy added the 🐛 type/bug This is a problem label Oct 8, 2020
@wooorm wooorm changed the title Crashes if table described in one line HTML parser: crashes if table described in one line Oct 19, 2020
@wooorm wooorm mentioned this issue Apr 9, 2021
Merged
wooorm added a commit that referenced this issue Apr 12, 2021
@wooorm
Replace renderers w/ components, remove HTML parser from core (#563)
77c680f 
* Replace `renderers` w/ `components`
* Replace `allowNode` w/ `allowElement`, which is now given a hast element (as
  the first parameter)
* Replace `allowedTypes` w/ `allowedElements`
* Replace `disallowedTypes` w/ `disallowedElements`
* Change signature of `linkTarget` and `transformLinkUri`, which are now given
  hast children (as the second parameter)
* Change signature of `transformImageUri`, which is now given the `alt` string
  as the second parameter (instead of the fourth)
* Replace `plugins` w/ `remarkPlugins` (backwards compatible change)
* Add `rehypePlugins`
* Change `includeNodeIndex` to `includeElementIndex`: it still sets an `index`,
  but that value now represents the number of preceding elements, it also sets a
  `siblingCount` (instead of `parentChildCount`) with the number of sibling
  elements in the parent
* The `columnAlignment` prop is no longer given to table elements: it’s
  available as `style` on `th` and `td` elements instead
* The `spread` prop is no longer given to list elements: it’s already handled

Remove buggy HTML parsers from core

* If you want HTML, add [`rehype-raw`](https://github.com/rehypejs/rehype-raw)
  to `rehypePlugins` and it’ll work without bugs!
* Remove `allowDangerousHtml` (previously called `escapeHtml`) option: pass
  `rehype-raw` in `rehypePlugins` to allow HTML instead
* Remove `with-html.js`, `plugins/html-parser.js` entries from library
* Remove naïve HTML parser too: either use `rehype-raw` to properly support
  HTML, or don’t allow it at all

Closes GH-549.
Closes GH-563.

The following issues are solved as rehype is now available:

Closes GH-522.
Closes GH-465.
Closes GH-427.
Closes GH-384.
Closes GH-356.

The following issues are solved as a proper HTML parser (`rehype-raw`) is now
available:

Closes GH-562.
Closes GH-460.
Closes GH-454.
Closes GH-452.
Closes GH-433.
Closes GH-386.
Closes GH-385.
Closes GH-345.
Closes GH-320.
Closes GH-302.
Closes GH-267.
Closes GH-259.

The following issues are solved as docs are improved:

Closes GH-251.
@wooorm
Copy link
Member

wooorm commented Apr 12, 2021

This should be solved by landing GH-563 today, which will soon be released in v6.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace renderers w/ components, remove HTML parser from core remarkjs/react-markdown
6 participants
@wooorm @ChristianMurphy @braska @te-online @nlucero @plainnany