Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for trailing newlines in commit messages #495

Merged
merged 1 commit into from Aug 23, 2022

Conversation

bernardcooke53
Copy link
Contributor

Resolves issue #490

@bernardcooke53
Copy link
Contributor Author

bernardcooke53 commented Aug 23, 2022

Note this is a bit brittle - but getting this out & preventing countless infinite loops in automated CI seems like a higher priority. Will need to check that commit messages are stripped for comparison. Changing in get_commit_log seems to break tests for changelog generation, so better to strip it at the comparison site for now imo.

The bug causing #490 is that in git logs, commit messages have a trailing newline, which isn't accounted for in the message built up from config.

Have added some extra test cases to check for this.

@d-ryzhikov - hopefully this doesn't break the testing/use case you had for implementing your PR?
@zjgoodman - does this fix #490 for you?
Also as @danth reviewed the first PR - I guess it'd help if you could review this too please?

@danth
Copy link
Member

danth commented Aug 23, 2022

Going to merge this straight away so that we don't affect any more repositories with the infinite looping.

@danth danth merged commit 111b151 into python-semantic-release:master Aug 23, 2022
@bernardcooke53 bernardcooke53 deleted the fix-issue-490 branch August 30, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants