Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't override tag matching to find the latest tag #944

Closed
husseinraoouf opened this issue Oct 3, 2022 · 6 comments
Closed

can't override tag matching to find the latest tag #944

husseinraoouf opened this issue Oct 3, 2022 · 6 comments
Labels

Comments

@husseinraoouf
Copy link
Contributor

Problem

I am trying to make the change log of normal releases contain all changes from the latest normal release until now even if there is pre releases in between

the problem is that git.tagMatch should be a globe so the suggested expression "[0-9]*\.[0-9]*\.[0-9]*" actually match normal and pre releases because the star at the end will allow any thing so 1.1.2-0 is valid

Suggested Solution

add a prefix for pre releases so we can match or exclude it with a globe

@webpro
Copy link
Collaborator

webpro commented Oct 4, 2022

Not sure I understand the issue. The tagMatch value is a glob. When the glob matches both normal releases and prereleases, all releases should be included.

Do you want to exclude the prereleases and only include the commits/changes from the normal releases? You could use something like "[!-]*" to exclude tags having the -.

@husseinraoouf
Copy link
Contributor Author

husseinraoouf commented Oct 4, 2022

Do you want to exclude the prereleases and only include the commits/changes from the normal releases?

exactly yes

You could use something like "[!-]*" to exclude tags having the -.

I tired that, but this glob pattern actually match all tags that doesn't start with - not the tags that doesn't contain - because the * here is different than regex, in glob * means match any thing ( not anything like the previous pattern like in regex )

@husseinraoouf
Copy link
Contributor Author

@webpro any updates,

I could help if you need

@webpro
Copy link
Collaborator

webpro commented Mar 9, 2023

Did you see #963? Does that help? I'd be happy to look into a better fix.

@stale
Copy link

stale bot commented May 21, 2023

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label May 21, 2023
@webpro
Copy link
Collaborator

webpro commented Jul 9, 2023

Perhaps the recent addition of https://github.com/release-it/release-it/blob/main/docs/git.md#use-all-refs-to-determine-latest-tag is helpful here.

Closing due to inactivity.

@webpro webpro closed this as completed Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants