Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped plugin names break context lookup #925

Closed
scalvert opened this issue Jul 25, 2022 · 1 comment · Fixed by #926
Closed

Scoped plugin names break context lookup #925

scalvert opened this issue Jul 25, 2022 · 1 comment · Fixed by #926

Comments

@scalvert
Copy link
Contributor

scalvert commented Jul 25, 2022 •
edited

When updating/renaming our plugins, release-it-yarn-workspaces and release-it-lerna-changelog, to their new scoped variants, @release-it-plugins/workspaces and @release-it-plugins/lerna-changelog, our context lookups are broken. It appears that release-it seemingly intentionally (but maybe inadvertently) strips the scope off the plugin's name.

It's unclear why it does this. @webpro - is there a reason why plugin names are mutated like this when loading?
@scalvert scalvert mentioned this issue Jul 25, 2022
Merged
@webpro
Copy link
Collaborator

webpro commented Jul 26, 2022

Not sure, to be honest, other than that it's over 2 years ago and maybe I didn't like @ and / in object keys or something.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes loading scoped plugins to ensure name is preserved scalvert/release-it
2 participants
@scalvert @webpro