Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab.milestones option to associate milestones with a release #883

Merged
merged 2 commits into from Mar 31, 2022

Conversation

j-ulrich
Copy link
Contributor

Closes #871

@webpro
Copy link
Collaborator

webpro commented Mar 25, 2022

Nice PR! Feel free to take from draft when it succeeds the checks, and I'll be happy to merge and release this.

@j-ulrich
Copy link
Contributor Author

There is one thing which is not nice: if one of the given milestones does not exist, GitLab rejects the request to create a release.

I think about adding a check whether the milestones exist.
What do you think? I guess this should be added in beforeRelease()? 🤔

@j-ulrich j-ulrich marked this pull request as ready for review March 30, 2022 18:34
@j-ulrich
Copy link
Contributor Author

Okay. I implemented a check for the milestones in beforeRelease(). It aborts if one of the milestones is missing. The check can be disabled by setting gitlab.skipChecks: true.

@webpro webpro merged commit af0882f into release-it:master Mar 31, 2022
@webpro
Copy link
Collaborator

webpro commented Mar 31, 2022

Thanks @j-ulrich, great PR! It's in v14.14.0

@j-ulrich j-ulrich deleted the feature/issue-871 branch April 3, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow associating milestones when creating GitLab release
2 participants