New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for custom tag name when retrieving latest tag #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing a test fail with |
@webpro, any insight on the failing test? |
SuaYoo
added a commit
to team-telnyx/webrtc
that referenced
this pull request
Jan 26, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #708, based on @jsamr's suggestion (#708 (comment))
Context
We're differentiating releases between monorepo packages by prefixing tags with
packageName/v
. I realized that the latest tag applied to the entire repo, which was not the behavior I expected when specifying a customtagName
.Prior to proposed changes, you can see that running
release-it
for a package named "react-client" returns the latest tag for the "webrtc" package, which is in the same repo:Both latest tag and conventional-changelog works as expected after applying proposed changes: