Fix prerelease continuation increased patch version in CI mode #715
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that I've broken some tests will have a look into it tomorrow. |
pstrh
commented
Oct 27, 2020
webpro
reviewed
Oct 28, 2020
|
@webpro Couldn't look into this until now. Thank you for finisihing and merging this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@webpro This PR tries to solve #714 - which I've introduced via #707
Problem was that the 'patch' default in the CI mode previously did not had an effect in a prerelease continuation scenario. With #707 the default patch increment is applied.
To solve this the prelease shortcut has to be detected first. Only if it's not the prerelease shortcut the increment can be set to 'patch' in CI mode. To be able to implement this evaluation order I added a optional isCI flag to the incrementVersion method.
I also added some additional tests to verify the fix.