New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14.2.0 adds new required getIncrement
method breaking existing plugins
#713
Comments
I think personally that I'd like to resolve this by making |
This is important because a release-it setup created by rwjblue/create-release-it-setup should generally have all release-it dependencies be a similar range (so that they can be de-duplicated) to avoid issues like release-it/release-it#713
Yes, It's in https://github.com/release-it/plugin-starterkit/blob/master/package.json, but I didn't really think ahead of the issue you faced (i.e. for existing plugins) and document/announce this properly. Apologies for any issues you may have had! Will try to do better next time. |
Gotcha, yeah. Though the starter kit only recently moved
I think it may make sense to explicitly call this out in the plugin documentation for new plugin authors.
Absolutely no worries here! I mostly just wanted to raise the issue so folks using my release setup have a chance to find the issue when they search github for it 😄. I'll cross link here when I've got new versions of |
Didn't expect you to! Just pointing that new plugin authors hopefully see it. It wasn't even linked to from the plugin docs, so now it is.
Yes! Just did. Thank you very much for the suggestion. Thanks again, Robert! Closing this issue for now. |
Fixes issue reported in release-it/release-it#713
Existing plugins generally depend on
release-it
itself in order to extend from the built-inPlugin
base class. Unfortunately, that means (due to lock files with both yarn and npm) that often times multiple versions ofrelease-it
'sPlugin
base class.For example, a sample project using `release-it` and `release-it-lerna-changelog` has these versions
As a result, the change in #710 is basically a breaking change for users of plugins.
The text was updated successfully, but these errors were encountered: