Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after:git:release hook not executed #705

Closed
j-ulrich opened this issue Sep 17, 2020 · 1 comment
Closed

after:git:release hook not executed #705

j-ulrich opened this issue Sep 17, 2020 · 1 comment

Comments

@j-ulrich
Copy link
Contributor

I try to use the after:git:release hook but it is not executed. It isn't logged in a --dry-run either.

If I use after:git:afterRelease instead, the hook is executed and also logged in --dry-run.

In case it matters, my config also has these settings:

	"git": {
		"tag": false,
		"push": false
	},
	"npm": {
		"publish": false
	},

I also tried it when setting the git settings to true but it's the same: after:git:release is not executed but after:git:afterRelease is executed.

This is how the end of the output from a dry run looks like with after:git:release hook:

? Commit (Release 0.5.1)? Yes
! git commit --message Release 0.5.1
🏁 Done (in 3s.)

In contrast, the same config but just replacing after:git:release with after:git:afterRelease:

? Commit (Release 0.5.1)? Yes
! git commit --message Release 0.5.1
! echo "hello from the after:git:afterRelease hook!"
🏁 Done (in 2s.)

I'm using version 14.0.3.

@webpro webpro closed this as completed in 229ed75 Sep 18, 2020
@webpro
Copy link
Collaborator

webpro commented Sep 18, 2020

Only when the git push was successful, it will execute the after:git:release hook. Same goes for e.g. the npm publish (after:npm:release hook). I just added a line in the docs about this, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants