New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GitHub Actions #621
Conversation
Thanks, @vinsidious! What's the reason you made the variable part of the global config? I think we can/should keep its scope entirely within the GitHub plugin. |
@webpro I actually went back and forth with that decision. I think my rationale was: if the execution environment was within a GitHub Action, that's on the global level and sort of pervades every other action/plugin. That being said, you obviously have way more context here and I also agree with you. I'll make the change 👍 |
Makes total sense. But I think e.g. the npm plugin is not interested in this. If this ever changes we can of course move it up again. |
@webpro Hopefully this is what you had in mind? Please let me know if this isn't the right approach |
@webpro Looks like the tests are passing but I do want to call out that I've noticed them being a little iffy. I imagine it has something to do with ava's concurrency but appending |
@vinsidious Do you recall what kind of errors you were seeing? I'm on macOS, so if you're using something different this might be useful info. |
I'm on macOS as well, but the logs from the failed tests on GitHub are the same as the errors I was getting locally. I was able to consistently repro by commenting/uncommenting the line that sets |
Thanks a lot, @vinsidious! Merged and released as v13.2.0-beta.0. |
Overview
This PR adds support for running
release-it
on GitHub Actions and fixes #618.Background
When running on GitHub Actions, GitHub injects the
GITHUB_TOKEN
environment variable automatically. This token differs from typical GitHub user tokens in the following ways:Because of this, we need to skip the user authentication and collaborator checks when we're running on GitHub Actions.
Example of this running successfully