-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nothing happens after before:init hook runs #574
Comments
So when you use |
Correct, it hangs with any hooks without verbose mode but works with the verbose flags |
Not sure what command/output causes this. Apparently in your situation it doesn't matter which command is executed first, right? Then I don't know what causes this. Can you provide a repo or something I can check out? |
Out of curiosity, I tried a basic create-react-app setup (as Let me know if you have a similar setup and maybe have customized something that causes the issue. Use |
Hello, |
Thanks @websilone. I've released https://github.com/release-it/release-it/releases/tag/12.5.0-next.3 that might fix this issue. If you guys could try this on your environment, that would be great. Not sure what else I could do about this. I guess the request to GA might fail e.g. when behind a proxy or something, but it should fail silently after 300ms. |
I'm closing this issue. If someone still has this problem, please let me know. Ideally, this comes with a reproducible case. |
I have a before:init hook as follows:
"before:init": ["npm run test:release", "npm run lint"],
and when I run it I see npm run test:release in the console. It completes and the green tick shows up but nothing happens next - the console just hangs there.I've tried switching the order of the commands too and the same thing happens after the first command is run.
The two commands above are:
"test:release": "cross-env CI=true react-scripts test --env=jsdom", "lint": "prettier --check src/**/* && eslint src/**/*",
If I remove the hook it works fine.It wasn't the removing the hook that made it work, but rather supplying --V --VV to the command...
The text was updated successfully, but these errors were encountered: