Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin requires npm login, even if npm publish disabled #66

Open
alextompkins opened this issue Dec 16, 2021 · 2 comments
Open

Plugin requires npm login, even if npm publish disabled #66

alextompkins opened this issue Dec 16, 2021 · 2 comments

Comments

@alextompkins
Copy link

alextompkins commented Dec 16, 2021

It looks like this plugin somehow causes release-it to require npm login, even if the npm publish step is disabled. My release-it.json looks like the following:

{
  "git": {
    "requireBranch": "main",
    "tagName": "v${version}"
  },
  "github": {
    "release": true,
    "web": true
  },
  "npm": {
    "publish": false
  },
  "plugins": {
    "release-it-yarn-workspaces": true
  }
}

And my root package.json includes the two packages I have under a subdirectory:

  "workspaces": [
    "packages/*"
  ]

When I run release-it with this configuration, it asks me to authenticate, even though I'm not publishing to NPM.
image

@alextompkins
Copy link
Author

Apologies, I see now that the skipChecks option provides me the ability to avoid this 💯

However, it seems to me like this should be the default, as release-it by default doesn't require you to be authenticated if NPM publishing is disabled.

@MGough
Copy link

MGough commented Mar 25, 2022

We encountered this issue too having adopted release-it-yarn-workspaces in addition to a release-it config we've been running for ~6 months now. It's particularly tricky as it only presented itself in CI, whereas running locally did not encounter this issue, we weren't expecting this failure as we'd set NPM publish to false at both levels:

    "release-it-yarn-workspaces": {
      "publish": false,
      ...
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants