Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against npm@7 #41

Open
rwjblue opened this issue Oct 16, 2020 · 1 comment
Open

Test against npm@7 #41

rwjblue opened this issue Oct 16, 2020 · 1 comment

Comments

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 16, 2020

In theory this package should work exactly the same under npm as it does under yarn. We do not currently shell out to yarn at all, we use npm publish to actually publish each package already:

https://github.com/rwjblue/release-it-yarn-workspaces/blob/4480e0bab42b3aab35539bc1e9ee2d3fdc80fec1/index.js#L405

@scalvert
Copy link
Collaborator

I don't even know what there would be to test, because all this cares about is that you have a workspaces setup in your project. It looks as though workspaces support in npm 7 works the same as yarn, so I believe this should 'just work'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants