Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support independent workspaces #59

Closed
wants to merge 2 commits into from

Conversation

xg-wang
Copy link

@xg-wang xg-wang commented Aug 2, 2021

Fixes #40

When specified in package.json "independentWorkspaces" option, prompt to
ask for version the workspace should be updated to.

TODO:

  • semver choices before asking text input
  • figure out CI
  • distTag for independent workspaces
  • per workspace changelog generation?
Example output
❯ yarn release-it --dry-run
yarn run v1.22.10
$ /Users/xwang5/Code/fb/ember-cli-fastboot/node_modules/.bin/release-it --dry-run
$ git describe --tags --abbrev=0
$ /Users/xwang5/Code/fb/ember-cli-fastboot/node_modules/lerna-changelog/bin/cli.js --next-version=Unreleased --from=v3.2.0-beta.2
! npm ping --registry https://registry.npmjs.org
! npm whoami --registry https://registry.npmjs.org
$ git diff --quiet HEAD
$ git rev-parse --abbrev-ref HEAD
$ git config --get branch.master.remote
$ git remote get-url origin
! git fetch
$ git describe --tags --abbrev=0  [cached]
$ git symbolic-ref HEAD
$ git for-each-ref --format="%(upstream:short)" refs/heads/master
$ git rev-parse --abbrev-ref HEAD  [cached]
$ git config --get branch.master.remote  [cached]
$ git remote get-url origin  [cached]
! git fetch
$ git describe --tags --abbrev=0  [cached]

🚀 Let's release ember-cli-fastboot (currently at 3.2.0-beta.2)


Changelog:
## Unreleased (2021-08-02)
#### :boom: Breaking Change
* `ember-cli-fastboot`, `fastboot-app-server`, `fastboot-express-middleware`, `fastboot`
  * [#834](https://github.com/ember-fastboot/ember-cli-fastboot/pull/834) Update using ember-cli-update and drop support for Node 10 ([@mansona](https://github.com/mansona))
* `ember-cli-fastboot`
  * [#825](https://github.com/ember-fastboot/ember-cli-fastboot/pull/825) Drop module unification support ([@xg-wang](https://github.com/xg-wang))
  * [#820](https://github.com/ember-fastboot/ember-cli-fastboot/pull/820) Remove deprecated features for ember-cli-fastboot v3 release ([@xg-wang](https://github.com/xg-wang))
#### :rocket: Enhancement
* `ember-cli-fastboot`
  * [#814](https://github.com/ember-fastboot/ember-cli-fastboot/pull/814) Throw a helpful error when people use `isFastboot` instead of `isFastBoot` ([@bertdeblock](https://github.com/bertdeblock))
* `fastboot-app-server`
  * [#811](https://github.com/ember-fastboot/ember-cli-fastboot/pull/811) [fastboot-app-server] turn on gzip by default ([@xg-wang](https://github.com/xg-wang))
#### :memo: Documentation
* [#810](https://github.com/ember-fastboot/ember-cli-fastboot/pull/810) doc: update CONTRIBUTING.md for code structure and tests ([@xg-wang](https://github.com/xg-wang))
#### :house: Internal
* `ember-cli-fastboot`, `fastboot-app-server`, `fastboot-express-middleware`, `fastboot`
  * [#821](https://github.com/ember-fastboot/ember-cli-fastboot/pull/821) Convert co to async in test; cleanup some configurations ([@xg-wang](https://github.com/xg-wang))
#### Committers: 5
- Ankush Dharkar ([@ankushdharkar](https://github.com/ankushdharkar))
- Bert De Block ([@bertdeblock](https://github.com/bertdeblock))
- Chris Manson ([@mansona](https://github.com/mansona))
- Dave Laird ([@kiwiupover](https://github.com/kiwiupover))
- Thomas Wang ([@xg-wang](https://github.com/xg-wang))

? Select increment (next version): patch (3.2.0)
? Please enter a valid version for the independent fastboot-app-server, from 3.2.0-beta.2: 3.2.0-beta.3
$ Processing packages/ember-cli-fastboot/package.json:
$ 	version: -> 3.2.0 (from 3.2.0-beta.2)
$ 	dependencies: `fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ 	dependencies: `fastboot-express-middleware` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing packages/fastboot-app-server/package.json:
$ 	version: -> 3.2.0-beta.3 (from 3.2.0-beta.2)
$ 	dependencies: `fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ 	dependencies: `fastboot-express-middleware` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing packages/fastboot-express-middleware/package.json:
$ 	version: -> 3.2.0 (from 3.2.0-beta.2)
$ 	dependencies: `fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing packages/fastboot/package.json:
$ 	version: -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for ./package.json:
$ Processing additionManifest.dependencyUpdates for test-packages/basic-app/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for test-packages/custom-fastboot-app/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for test-packages/custom-sandbox-app/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for test-packages/ember-cli-fastboot-testing-app/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for test-packages/example-addon/package.json:
$ Processing additionManifest.dependencyUpdates for test-packages/fake-addon-2/package.json:
$ Processing additionManifest.dependencyUpdates for test-packages/fake-addon/package.json:
$ Processing additionManifest.dependencyUpdates for test-packages/hot-swap-app/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.dependencyUpdates for test-packages/integration-tests/package.json:
$ 	devDependencies: `ember-cli-fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ 	devDependencies: `fastboot` -> 3.2.0 (from 3.2.0-beta.2)
$ Processing additionManifest.versionUpdates for ./package.json:
$ 	version: -> 3.2.0 (from 3.2.0-beta.2)
! Prepending CHANGELOG.md with release notes.
$ git status --short --untracked-files=no

Empty changeset

! git add . --update
? Commit (Release 3.2.0)? (Y/n) 

When specified in package.json "independentWorkspaces" option, prompt to
ask for version the workspace should be updated to.

TODO:
- semver choices before asking text input
- figure out CI
- distTag for independent workspaces
@xg-wang
Copy link
Author

xg-wang commented Aug 8, 2021

Independent versioning in a mono repo has its quirks. Versioning/tagging can be confusing. The best is to publish same version if possible

@xg-wang xg-wang closed this Aug 8, 2021
@xg-wang xg-wang deleted the independent branch August 8, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there support for independent versioning?
1 participant