Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support yarn berry version plugin? #37

Open
jsamr opened this issue Aug 31, 2020 · 1 comment
Open

Does it support yarn berry version plugin? #37

jsamr opened this issue Aug 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jsamr
Copy link

jsamr commented Aug 31, 2020

I have not seen mentions in the README; this official Yarn plugin is documented here: Yarn | Release Workflow.

Basically, to support this plugin, you would defer version generation to yarn version command. Perhaps you could add a config / flag to enable it!

@rwjblue
Copy link
Collaborator

rwjblue commented Aug 31, 2020

Thanks for opening this issue!

At the moment, we expect the actual version number to be chosen by the user in release-it's normal workflow, then we directly assign the package.json's version to that value:

https://github.com/rwjblue/release-it-yarn-workspaces/blob/268235c91d6481730b245ecf4e9d1744ab542674/index.js#L192-L205

Then we also manually traverse the dependencies listed in package.json's workspaces configuration to bump the corresponding versions.


It looks like we could use a few of the slated features that you referenced from the documentation:

https://github.com/rwjblue/release-it-yarn-workspaces/blob/268235c91d6481730b245ecf4e9d1744ab542674/index.js#L211

@rwjblue rwjblue added the enhancement New feature or request label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants