Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autolabeler #774

Merged
merged 1 commit into from Feb 11, 2021
Merged

Conversation

rofafor
Copy link
Contributor

@rofafor rofafor commented Feb 1, 2021

As release-drafter is catogorizing releases notes based on labels, it's nice to integrate optional labeling support as well. Check the README for configuration.
image
image

@jetersen
Copy link
Member

jetersen commented Feb 1, 2021

Hmm an action already exists for this: https://github.com/actions/labeler
I wonder if you could use the trick I did for https://github.com/release-drafter/release-drafter/blob/master/action.js to get that as a probot?

@jetersen
Copy link
Member

jetersen commented Feb 1, 2021

Hmm, I like where this is heading though and it does seem different enough from actions/labeler.

@rofafor
Copy link
Contributor Author

rofafor commented Feb 1, 2021

The actions/labeler supports only file paths, but this one tracks also branch naming (for those using gitflow naming scheme), PR titles and descriptions (fix/bug/etc. keywords, ticketing system ids).

index.js Show resolved Hide resolved
lib/template.js Outdated Show resolved Hide resolved
@rofafor rofafor force-pushed the feature/autolabeler branch 4 times, most recently from 656288a to 2e5295a Compare February 10, 2021 17:02
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nitpick than we are ready to merge.

package.json Outdated Show resolved Hide resolved
@jetersen jetersen added the type: feature New feature or request label Feb 11, 2021
@jetersen jetersen merged commit f9f0116 into release-drafter:master Feb 11, 2021
@rofafor rofafor deleted the feature/autolabeler branch February 11, 2021 08:19
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants