Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category templating #767

Merged
merged 2 commits into from Jan 28, 2021
Merged

Conversation

rofafor
Copy link
Contributor

@rofafor rofafor commented Jan 27, 2021

I wanted to avoid the hard-coded category title markdown, i.e. change it from ## Features to ### Features to be a bit more subtle.

@rofafor rofafor force-pushed the feature/templates branch 2 times, most recently from 7a4972c to e02a475 Compare January 27, 2021 17:16
@rofafor rofafor force-pushed the feature/templates branch 2 times, most recently from 15f6edd to 7dd8a6c Compare January 27, 2021 18:01
@jetersen jetersen changed the title Flexible templating Category templating Jan 27, 2021
@jetersen
Copy link
Member

jetersen commented Jan 27, 2021

Please rebase onto master and run yarn install to get the latest @vercel/ncc than rerun yarn build to avoid the many thousand of changes inside dist/index.js

@rofafor
Copy link
Contributor Author

rofafor commented Jan 28, 2021

Thanks. I had some odd issues for generating the file on my MAC: all kind of CRLF issues no matter which core.autocrlfsetting I was using. Looks better now.

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for contributing! 👏

@jetersen jetersen added the type: feature New feature or request label Jan 28, 2021
@jetersen jetersen merged commit 8ef32da into release-drafter:master Jan 28, 2021
@rofafor rofafor deleted the feature/templates branch January 28, 2021 11:01
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants