Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No draft release found" when running CD #680

Closed
wjk opened this issue Oct 19, 2020 · 3 comments
Closed

"No draft release found" when running CD #680

wjk opened this issue Oct 19, 2020 · 3 comments

Comments

@wjk
Copy link

wjk commented Oct 19, 2020

Please take a look at this GitHub Actions workflow file. This file is supposed to run release-drafter both to move the Draft release it maintains to the tag I just pushed, and to obtain the upload_url output so I can upload prebuilt artifacts to it later. However, every time I push a tag, the action gives me the following output:

Found 5 releases
No draft release found
No last release found
Fetching all commits for reference refs/tags/v1.2.1-rc.1
Creating new release

release-drafter then proceeds to ignore the draft release it maintains (which is still updated correctly when I merge a PR; I tested that) and creates a new one with an unset version (containing $RELEASE_VERSION verbatim in the text and a meaningless hashed tag), that lists every PR ever merged into the repo since it was created.

What I want to have happen is if I push the tag v1.2.1, it moves the untagged Draft release to the v1.2.1 tag, ensures that only PRs merged between now and when the previous version was published are displayed, then returns the upload_url for later use. How can I configure release-drafter to do this? I do not want to publish the release automatically when the action is run, as one final safety check so I can edit anything if I need to before I make it available to the world. Please also be aware of the following caveats:

  • I must run release-drafter in a separate job before my build, because I am building a Windows app and release-drafter only runs on a Linux image.
  • I cannot split the build job into two parts (and run release-drafter in-between), as then the release assets would be deleted when the first job finishes, making it impossible to upload them in the second job.

I hope I've explained this clearly; it is a very confusing problem for me. If you have any other questions, please feel free to ask. Thanks so much!

@valentijnscholten
Copy link

I saw the same, but was caused by #681

@jetersen
Copy link
Member

Hopefully reverting #657 should fix it.

@wjk
Copy link
Author

wjk commented Oct 20, 2020

Using v5.12.1 of release-drafter fixed the problem; it now works like a charm. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants