Make the generated schema compliant with draft04 #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The schema was containing an empty required array which is incompatible with the draft 04 specification.
2 tasks
ssbarnea
approved these changes
Aug 16, 2020
|
@jetersen any way to get this PRs moving? I would like to get it to finish up jenkinsci/.github#21. |
timja
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema was containing an empty array for the required field, which is incompatible with the draft 04 specification.
I hesitated to simply remove the field as technically we are currently filtering a list containing a single element, however I fear it's error prone for the future.
Tell me if the js code is wrong, js is not really my strong suit, happy :)