Update example in README to use version resolution #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration example in readme has a `version-resolver` section with labels that supposed to control the version name / tag strings. However, this example dos not work out of the box, which could be frustrating, especially for new users. This PR is to update name/tag templates with `$RESOLVED_VERSION`, so the version labels, if present, will actually be used.
jetersen
approved these changes
Jun 20, 2020
|
Thanks for catching that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration example in
README.mdhas aversion-resolversection with labels that supposed to control the version name / tag strings. However, this example dos not work out of the box, which could be frustrating, especially for new users.This tiny PR is to update name/tag templates with
$RESOLVED_VERSION, so the version labels, if present, will actually be used.