Changes from pushes to master (without a PR)

[ianwalter]

I couldn't find an issue related to this so sorry if this is redundant but can release drafter add changes for commits to master not added through a pull request? It doesn't seem like there is a way to do this. If so, are there any workarounds for this?

[jetersen]

We have the data to do it as we are pulling commits and associated pull requests, but since it falls outside the categorization. The data is not used.

[ianwalter]

Thank you that is very helpful to understand. Maybe there should be a default "Other Changes" category or that data can be added to a $OTHER_CHANGES variable? I did see someone asking about integration with Conventional Commits which I think could be related to this as well.

[adrianthedev]

I see this as a valid use case too.

[albertpastrana]

We'd love release drafter but we do trunk based development (i.e. no prs) and can't use it because of that.

Do you think this is something that will get some attention @jetersen ?

[jetersen]

Only if those doing trunk based development want to contribute 😓

I myself do not use trunk based development so I am not qualified deem what is needed.

[albertpastrana]

Thanks a lot for the quick answer. I'm afraid I don't have the time right now to help (specially because I'm going to take some days off :-)). I will see if I can help. From a user point of view my requirement could be described as. As a github user with different workflows in my company I'd love it if your tool could gather the changes between based on the list of commits in a main branch (master/trunk/main...) from the latest release to now So that my teams can develop either using pull requests or pushing directly to that main branch as needed Thanks again

…

On Thu, 6 Aug 2020 at 13:39, Joseph Petersen ***@***.***> wrote: Only if those doing trunk based development want to contribute 😓 I myself do not use trunk based development so I am not qualified deem what is needed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#552 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO2GQDD6OLCCVV5E62PEDTR7KI7PANCNFSM4NQ35MDA> .

[matfax]

I would suggest matching semantic commit messages for its underlying categories.
There's the Conventional Commits convention 1.0.0, for example.

fix => Fix
feat => Feature
docs => Documentation
! prefix => minor/major feature

Besides the default set of type tags, the user could also be let to configure their own tags with linked categories.

[lucagiove]

Another situation that is not working is having PR merged in a branch than merged to master.
Esample
pr-1 -> release-branch
pr-2 -> release-branch
pr-release-branch -> master

Changelog considers only pr-release-branch

[ghost]

I would like also to add my usecase to this discussion.

I have a module that I publish to pypi, but its small and its only me that works on it. I do use PRs for most features and I have workflows setup to run unit tests for every PR, but sometimes the changes are very small (updating a configuration file or documentation for example) that I do not want to have the action runners triggered for, so I just push to master directly with a commit.

Sometimes, these changes dont matter much, but other times it would be nice to include them as part of the release drafter, like for example I've updated setuptools to include dependencies now (which means im changing my docs to not including installing dependencies separately to my module)

This is absolutely a small concern and an edge case. But thought I would put in my usecase as it definitely would be handy to have some way to say "include this commit to master in the release draft".

[jetersen]

I do not see the feature being supported as there is no way to label commits unless your using conventional commits or some other way of categorizing commits.

If anyone is willing to contribute conventional commits support it might be worthwhile.

But I guess not everyone here is on the conventional commits train when doing trunk based development.

[jetersen]

Another situation that is not working is having PR merged in a branch than merged to master. Esample pr-1 -> release-branch pr-2 -> release-branch pr-release-branch -> master

Changelog considers only pr-release-branch

No longer true. Release-drafter will now attempt to draft according to the target reference.
Thanks to #1065

[jetersen]

Thank you that is very helpful to understand. Maybe there should be a default "Other Changes" category or that data can be added to a $OTHER_CHANGES variable? I did see someone asking about integration with Conventional Commits which I think could be related to this as well.

Other changes was fixed in #1013

[palanga]

Can't we just put those "uncategorized" commits on an "uncategorized" category instead of discard them ?

[mehdihadeli]

google-github-actions/release-please-action do this with conventional commits and categorize them based on the conventional commits type.