Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pull requests in the draft #1382

Open
bonanitech opened this issue Mar 9, 2024 · 2 comments
Open

Missing pull requests in the draft #1382

bonanitech opened this issue Mar 9, 2024 · 2 comments

Comments

@bonanitech
Copy link

Hi guys! This is my first (and hopefully the last 😃) time opening an issue in this fantastic project.

I don't know if I did something wrong, but for some reason, two PRs are not present in the draft of my next release. Any new PRs are automatically included in the draft without issues. Only those two aren't.

The missing PRs are node-red-contrib-themes/theme-collection#368 and node-red-contrib-themes/theme-collection#369.

How can I get that fixed?

Thanks.

image
@bonanitech
Copy link
Author

bonanitech commented Mar 15, 2024

After some tests in a private repository, I got the impression that the problem was that some labels had a blank space in the name.

node-red-contrib-themes/theme-collection#398

Boy, was I wrong! I forgot to rename the label in that repo, which made me think Release Drafter stopped working because of the spaces in the labels. 🤦🏼‍♂️ So I renamed the label and re-ran the workflow. Everything worked as expected.

Unfortunately, the issue persists in my public repo. I'm wondering if the PRs below somehow broke Release Drafter for me. Nothing before them appears in the draft.

@bonanitech
Copy link
Author

I feel so dumb about my previous comment.

Reading the debug logs, I found this:

2024-04-17T14:35:58.6831506Z node-red-contrib-themes/theme-collection: Fetching parent commits of refs/heads/dev since 2024-03-01T20:19:50Z.

That's the date and time of the latest tag creation (https://github.com/node-red-contrib-themes/theme-collection/releases/tag/3.1.11), and the missing pull requests are from an earlier date.

Will I have to add the missing PRs myself to the release notes, or is there something I can change in the settings so they are included automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant