Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing inputs to action config #1202

Merged

Conversation

gilbertsoft
Copy link
Contributor

Providing header or footer leads to a warning and the inputs are ignored
by the action. These two inputs are explicitly mentioned at
https://github.com/release-drafter/release-drafter#action-inputs. This
patch fixes the behavior to finally comply with the docs.

Providing header or footer leads to a warning and the inputs are ignored
by the action. These two inputs are explicitly mentioned at
https://github.com/release-drafter/release-drafter#action-inputs. This
patch fixes the behavior to finally comply with the docs.
@jetersen jetersen merged commit 6e6a13c into release-drafter:master Aug 16, 2022
@jetersen
Copy link
Member

jetersen commented Aug 16, 2022

Sorry, my bad for always forgetting action.yaml

I'll try and include tests for it in v6 👏

@jetersen jetersen added the type: bug Something isn't working label Aug 16, 2022
@jetersen
Copy link
Member

@gilbertsoft gilbertsoft deleted the bugfix/add-missing-inputs branch August 16, 2022 08:21
@gilbertsoft
Copy link
Contributor Author

Yeah, tests are always good for these kind of stuff :) Thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants