Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add issues linked to the PR instead of the PR itself to release draft #1136

Open
dreinon opened this issue May 6, 2022 · 7 comments · May be fixed by #1165
Open

feat: Add issues linked to the PR instead of the PR itself to release draft #1136

dreinon opened this issue May 6, 2022 · 7 comments · May be fixed by #1165

Comments

@dreinon
Copy link

dreinon commented May 6, 2022

Hi! First of all, thanks for this awesome project, it's really helpful.

Github provides a way to link issues to a PR, which will get closed when the PR gets merged. Since there are cases where a single PR is opened to close multiple issues, it would be more descriptive to add the title of the issues linked to the PR in the release draft. Therefore, it would be nice to provide this option.

I know there is another issue related to draft releases based on issues (#501), but I think this issue is different, since this issue involves PRs and #501 does not.

Thanks!

@jetersen
Copy link
Member

Should be possible for someone to contribute 👏

They added recently added closingIssuesReferences to object schema

{
  resource(url: "https://github.com/Org/Repo/pull/1234") {
    ... on PullRequest {
      closingIssuesReferences(first: 10) {
        nodes {
          number
        }
      }
    }
  }
}

@dreinon
Copy link
Author

dreinon commented Jun 15, 2022

I can do it if you give me a couple insights on how to approach it 😃 @jetersen

@jetersen
Copy link
Member

I suggest looking at other pull requests: https://github.com/release-drafter/release-drafter/pull/531/files

@dreinon
Copy link
Author

dreinon commented Jun 15, 2022

Ok thanks!

@jetersen
Copy link
Member

https://github.com/release-drafter/release-drafter/blob/master/CONTRIBUTING.md has good insights and devcontainer should help development environment.

you can use GitHub Codespaces which should pickup the devcontainer.
Otherwise you can use vscode's devcontainer extension Remote - Containers

@dreinon dreinon linked a pull request Jun 16, 2022 that will close this issue
@TylerHendrickson
Copy link

@jetersen / @dreinon Is anyone still working on the pull request for this issue? Getting it approved and merged would be immensely helpful for us!

@dreinon
Copy link
Author

dreinon commented Nov 20, 2023

I'm not, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants