Add a collapse-after option for categories

[robbinjanssen]

This implements a new feature as discussed in #1093

Add the collapse-after integer to a category to make it hide the PRs if there are more than the given int.

[jetersen]

@robbinjanssen Please use yarn install and yarn prettier && yarn lint --fix && yarn build

using npm causes these large changeset in dist/index.js

[jetersen]

If you think this needs to be configurable, feel free to add it :)

Please follow the current config naming with word-another-word

[robbinjanssen]

We could, but I have no idea what to name it 🙈 Any suggestions?

[jetersen]

collapse-at is fine it will go together with collapse. The readme would have to document whether it is greater than or less than that is used.
The default may be greater than 3?

Potentially could move the condition to outside the if statement.

So the if statement might say if (shouldCollapse) or if (shouldNotCollapse)

[jetersen]

@rnorth @bsideup @kiview This might be interesting for you :) I see you used details on release notes for https://github.com/testcontainers/testcontainers-java

If you have any input that would be appreciated 😅

[rnorth]

Wow this is great! I've been doing this by hand and it's such a pain. Thank you!

The only input I'd offer would be around collapse-at. I definitely think this value being configurable makes a lot of sense.

I wonder if having both collapse and collapse-at is potentially confusing though. The behaviour can differ depending on whether one/both/other are set, and the user has to mentally internalise some boolean logic to know what will happen.

Would it be too radical to suggest having only collapse-at?

If not set, the behaviour would be to never collapse (use MAX_VALUE as the default). If set, collapse would be implicitly true when the length exceeds the value.

[jetersen]

Only having collapse-at makes a lot of sense 😄

Instead of using MAX_VALUE I suggest simply conditional based on whether collapse-at is 0. When zero do nothing, makes sense as 0 is the default value for an integer.

const shouldCollapse = collapseAt != 0 && category.pullRequests.length > collapseAt

whether it is >= or > I am not sure 😅

[robbinjanssen]

Great suggestions! collapse-at definitely makes sense, i'll try to update the pr as soon as i got some spare time!

[jetersen]

one more suggestion, perhaps collapse-after makes more sense :) So collapse-after: 3 would mean pullRequests.length > 3 would mean it collapses once it hits 4 😅

[robbinjanssen]

@jetersen done! Let me know if you want any more changes :-)

[jetersen]

41b8bf1 great addition 😄

[jetersen]

@rnorth do you mind reviewing it?

[jetersen]

@rnorth any concerns or do you think I can go ahead and merge?

If your too busy just let me know 😅

[rnorth]

@rnorth any concerns or do you think I can go ahead and merge?

If your too busy just let me know 😅

Sorry I'm off sick at the moment. I'm sure if you've reviewed then it's going to be fine. Thank you!

[jetersen]

@rnorth thanks and get well.

[jetersen]

@robbinjanssen thank you for your contribution.