Filter by commitish regardless of the refs/heads prefix
#1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeroll
force-pushed
the
fix-filter-by-commitish
branch
2 times, most recently
from
a276477
to
7bc8fbd
Compare
jetersen
reviewed
Feb 28, 2022
lib/releases.js
Outdated
| ? releases.filter( | ||
| (r) => | ||
| // `refs/heads/branch` and `branch` are the same thing in this context | ||
| targetCommitish.replace(headRefRegex, '') === |
There was a problem hiding this comment.
This replace can be done once instead of for reach release.
mikeroll
force-pushed
the
fix-filter-by-commitish
branch
from
7bc8fbd
to
dc24635
Compare
|
@mikeroll seems to work, tested it locally! 👍 |
jetersen
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem from #1065 (comment)
@robbinjanssen appreciate if you could test this!