Add header and footer

[mkurz]

Fixes #1047

[mkurz]

@jetersen After adding tests this is ready to review and hopefully merge. Thanks!

[jetersen]

Again thank you for your contribution 🙌

[mkurz]

Again thank you!

[jetersen]

I'll put a tag on first thing tomorrow 😉 but bedtime is calling 😊

[mkurz]

👍 Actually there is a bug regarding _extends in https://github.com/probot/octokit-plugin-config, I am working on a fix right now, so maybe we can wait with the release. Let's talk tomorrow.

[mkurz]

@jetersen That is the bug I was talking about which also affects release-drafter: probot/octokit-plugin-config#166
Fix is here: probot/octokit-plugin-config#167

[jetersen]

whether dependency supports .github repo _extends or not have nothing to do with header and footer? 🤔

[mkurz]

Actually we want to put footer in a main config and a couple of configs will extend from it, all placed within the .github repo. So for us we need both to work correctly, so that's why I thought lets wait for the octokit-plugin-config fix and put everything in one release.
However of course technically they are not related.
AFAIK releasing is just pushing tag, feel free to do so. However as soon as the octokit-plugin-config fix lands it would be nice to cut another release. Thanks!

[jetersen]

a release is only a tag away so meh 😅
See: https://github.com/release-drafter/release-drafter/blob/master/.github/workflows/release.yml

[mkurz]

@jetersen so we have a new release of octokit-plugin-config: https://github.com/probot/octokit-plugin-config/releases/tag/v1.1.5
Can you also release a new relase drafter version with that dependency? And also move the v5 tag? Thanks!

[jetersen]

@mkurz https://github.com/release-drafter/release-drafter/releases/tag/v5.18.1

[mkurz]

@jetersen Thank you very much! Have a nice weekend!