Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand vars in tag and name inputs #1049

Merged
merged 3 commits into from Feb 1, 2022
Merged

Expand vars in tag and name inputs #1049

merged 3 commits into from Feb 1, 2022

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Feb 1, 2022

Fixes #1048

@mkurz mkurz mentioned this pull request Feb 1, 2022
Closed
jetersen
jetersen approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Could you add a test.

You should be able to find a mention of GITHUB_ACTION inside index.test.js via search.

@mkurz mkurz force-pushed the expand_tag_name_inputs branch 2 times, most recently from a8dc8dc to 6a16a69 Compare February 1, 2022 13:04
@mkurz
Copy link
Contributor Author

mkurz commented Feb 1, 2022

@jetersen Done. Tests added (after some problems do get things running 😉). Can you merge?

jetersen
jetersen reviewed Feb 1, 2022
View reviewed changes
test/fixtures/config/config-with-name-and-tag-template.yml Outdated
Comment on lines 2 to 3
name-template: 'v1.2.3 (Code name: Hello World)'
tag-template: v3.4.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Could we use some $RESOLVED_VERSION so at least the test looks sane 😓 I cannot handle that your getting one version in name and a different in tag.

jetersen
jetersen requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓 Test output looks odd, would prefer the config was aligned and the test overrides the name or tag properly.

@mkurz
Copy link
Contributor Author

mkurz commented Feb 1, 2022

Better? What I want to show is that once the tag gets overriden, once the name.

@jetersen
Copy link
Member

jetersen commented Feb 1, 2022

Better? What I want to show is that once the tag gets overriden, once the name.

Much 😅 The tests clearly shows what your looking for 🙂

@jetersen jetersen merged commit db60e03 into release-drafter:master Feb 1, 2022
@jetersen
Copy link
Member

jetersen commented Feb 1, 2022

Thank you for your contribution 🙌

@mkurz mkurz deleted the expand_tag_name_inputs branch February 1, 2022 21:47
@mkurz
Copy link
Contributor Author

mkurz commented Feb 1, 2022

Thank you!

@mkurz mkurz mentioned this pull request Feb 1, 2022
Merged
@jetersen jetersen added the type: bug Something isn't working label Feb 3, 2022
@hernit hernit mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$RESOLVED_VERSION not expanded when set via action input
2 participants
@mkurz @jetersen