Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-deserialising ASN.1 values to work around bugs in PKI.js #141

Open
gnarea opened this issue Aug 24, 2020 · 0 comments
Open

Avoid re-deserialising ASN.1 values to work around bugs in PKI.js #141

gnarea opened this issue Aug 24, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@gnarea
Copy link
Member

gnarea commented Aug 24, 2020

I've been doing that to avoid burning more time on that bug, but we need to address the underlying issue and open a PR for PKI.js after debugging it.

The main reason to do this is performance.

We can find the instances where this is done by searching for "redeserialize".

@gnarea gnarea added the bug Something isn't working label Aug 24, 2020
@gnarea gnarea added this to the Production release milestone Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant